> On Wed, Nov 14, 2012 at 06:14:55PM +0100, Sebastian Andrzej Siewior wrote: >> +typedef struct usb_function *(*usb_func_alloc)(void); >> +typedef void (*usb_func_free)(struct usb_function *f); On Tue, Nov 20 2012, Felipe Balbi wrote: > isn't checkpatch.pl crying about this ? :-) > > In any case, if you really want to typedef, then most other type > definitions in the kernel will append _t. irqreturn_t, irq_handler_t, > acc_t, async_cookie_t, sector_t, region_t and so on. There is a bit of a mess with typedefs naming especially when it comes to function pointers, and if anyone cares about my opinion, I would suggest a “_fn” suffix instead. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
Attachment:
pgpm1EbIVWYmX.pgp
Description: PGP signature
