Re: [PATCH 11/16] usb/gadget: convert f_acm to new function interface with backwards compatibility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 14, 2012 at 06:15:01PM +0100, Sebastian Andrzej Siewior wrote:
> This patch converts f_acm into a module which uses the new function
> interface. It also converts one of its users that is g_serial to make
> use of it. The other users of it (g_nokia for instance) are still using
> the old include file system and should not notice the change at all. So
> they can be converter later independently.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
>  drivers/usb/gadget/Kconfig    |    4 ++
>  drivers/usb/gadget/Makefile   |    1 +
>  drivers/usb/gadget/acm_ms.c   |    2 +-
>  drivers/usb/gadget/cdc2.c     |    2 +-
>  drivers/usb/gadget/f_acm.c    |  110 +++++++++++++++++++++++++++++------------
>  drivers/usb/gadget/multi.c    |    2 +-
>  drivers/usb/gadget/nokia.c    |    1 +
>  drivers/usb/gadget/serial.c   |   81 ++++++++++++++++++++++++------
>  drivers/usb/gadget/u_serial.h |    2 +
>  9 files changed, 156 insertions(+), 49 deletions(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 18d2114..4889dfb 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -500,6 +500,9 @@ config USB_LIBCOMPOSITE
>  	tristate
>  	depends on USB_GADGET
>  
> +config USB_F_ACM
> +	tristate
> +
>  config USB_F_SS_LB
>  	tristate
>  
> @@ -784,6 +787,7 @@ config USB_GADGET_TARGET
>  config USB_G_SERIAL
>  	tristate "Serial Gadget (with CDC ACM and CDC OBEX support)"
>  	select USB_U_SERIAL
> +	select USB_F_ACM

same comment regarding CONFIG_USB_GADGET=m and CONFIG_USB_F_ACM=y.
Perhaps let user choose which functions s/he wants to enable ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux