Hi, On Wed, Nov 14, 2012 at 06:12:21PM +0100, Sebastian Andrzej Siewior wrote: > If we do have endpoints named like "ep-a" then bEndpointAddress is > counted internally by the gadget framework. > If we do have endpoints named like "ep-1" then bEndpointAddress is > assigned from the digit after "ep-". > If we do have both, then it is likely that after we used up the > "generic" endpoints we will use the digits and thus assign one > bEndpointAddress to multiple endpoints. > This theory can be proofed by using the completely enabled g_multi. > Without this patch, the mass storage won't enumerate and times out > because it shares endpoints with RNDIS. > This patch also adds fills up the endpoints list so we have in total > endpoints 1 to 15 in + out available while some of them are restricted > to certain types like BULK or ISO. Without this change the nokia gadget > won't load because the system does not provide enough (BULK) endpoints. > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> this looks ok to me. Since without this patch g_nokia and g_multi won't work, I wonder if we should Cc stable ? It sounds to me like we should, in that case, can you resend with a proper Cc: stable@vger tag and make sure subject states that you're fixing enumeration of g_nokia and g_multi with dummy somehow ? -- balbi
Attachment:
signature.asc
Description: Digital signature
