On Wed, Oct 31, 2012 at 09:32:35PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
>
> The File-backed Storage Gadget (g_file_storage) gadget has been replaced
> with Mass Storage Gadget (g_mass_storage) which uses the composite
> framework. This commit removes g_file_storage (and most references to it).
>
> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> ---
> Documentation/DocBook/gadget.tmpl | 2 +-
> Documentation/usb/mass-storage.txt | 15 +-
> drivers/usb/gadget/Kconfig | 30 +-
> drivers/usb/gadget/Makefile | 2 -
> drivers/usb/gadget/file_storage.c | 3656 ------------------------------------
> drivers/usb/gadget/net2280.c | 2 +-
> drivers/usb/gadget/pxa27x_udc.h | 2 +-
> drivers/usb/musb/musb_gadget.c | 5 +-
> 8 files changed, 13 insertions(+), 3701 deletions(-)
> delete mode 100644 drivers/usb/gadget/file_storage.c
Acked-By: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> I've left a few references where comment said something like “Tested
> with File Storage Gadget”.
>
> As for the last hunk of the patch:
>
> - * REVISIT an updated g_file_storage can set req->short_not_ok, which
> - * then becomes usable as a runtime "use mode 1" hint...
>
> as far as I can tell, req->short_not_ok is never said anywhere in the
> kernel...
Not anymore. In fact the storage gadgets were the only users of this option
and it was removed in fe69676530 ("usb: gadget: storage: fix mass storage
gadgets to work with Synopsys UDC").
After this change we managed to live without it and I don't see a reason why
we shouldn't remove this option.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
