Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> writes: > From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > While there fix a potential race condition, first set usbmisc, then call > usbmisc_set_ops(). This should be really two separate patches, both of which could use more elaborate commit messages. That is, if you unset variable, what kind of scenario it prevents, what exactly is the potential race condition, etc. Saves time for everybody. > > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> > --- > drivers/usb/chipidea/usbmisc_imx6q.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) I'd also move the renaming patch in front of everything else, but that's up to you. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
