Hello.
On 08/09/2012 06:38 PM, Shubhrajyoti D wrote:
> dma_controller_create is called only from musb_init_controller
> which is __devint so annotate dma_controller_create also with
> __devint.
> fixes the warn
> WARNING: vmlinux.o(.devinit.text+0x6fa8): Section mismatch in reference from the function musb_init_controller() to the function .init.text:dma_controller_create()
> The function __devinit musb_init_controller() references
> a function __init dma_controller_create().
> If dma_controller_create is only used by musb_init_controller then
> annotate dma_controller_create with a matching annotation.
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx>
> ---
> Changes from RFC remove the stray changes
> drivers/usb/musb/cppi_dma.c | 2 +-
> drivers/usb/musb/musb_dma.h | 2 +-
> drivers/usb/musb/musbhsdma.c | 2 +-
> drivers/usb/musb/tusb6010_omap.c | 2 +-
> drivers/usb/musb/ux500_dma.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
> diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c
> index 8637c1f..e19da82 100644
> --- a/drivers/usb/musb/cppi_dma.c
> +++ b/drivers/usb/musb/cppi_dma.c
> @@ -1316,7 +1316,7 @@ irqreturn_t cppi_interrupt(int irq, void *dev_id)
> }
>
> /* Instantiate a software object representing a DMA controller. */
> -struct dma_controller *__init
> +struct dma_controller *__devinit
> dma_controller_create(struct musb *musb, void __iomem *mregs)
> {
> struct cppi *controller;
You failed to also mark cppi_controller_start() and cppi_pool_init __devinit
which causes section mismatch warning on DaVinci... I'll send a patch.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
