On Thu, 8 Nov 2012, Felipe Balbi wrote:
> > Mark the *_overrides structures as __initdata.
>
> I just have one question here: What about all the ehci-*.c with their
> probe outside of .init.text ?
>
> $ git grep -e __devinit drivers/usb/host/ehci*.c
> drivers/usb/host/ehci-atmel.c:static int __devinit ehci_atmel_drv_probe(struct platform_device *pdev)
> drivers/usb/host/ehci-grlib.c:static int __devinit ehci_hcd_grlib_probe(struct platform_device *op)
> drivers/usb/host/ehci-orion.c:static int __devinit ehci_orion_drv_probe(struct platform_device *pdev)
> drivers/usb/host/ehci-platform.c:static int __devinit ehci_platform_probe(struct platform_device *dev)
> drivers/usb/host/ehci-ppc-of.c:static int __devinit
> drivers/usb/host/ehci-ppc-of.c:static int __devinit ehci_hcd_ppc_of_probe(struct platform_device *op)
> drivers/usb/host/ehci-ps3.c:static int __devinit ps3_ehci_probe(struct ps3_system_bus_device *dev)
> drivers/usb/host/ehci-s5p.c:static int __devinit s5p_ehci_probe(struct platform_device *pdev)
> drivers/usb/host/ehci-spear.c:static struct of_device_id spear_ehci_id_table[] __devinitdata = {
> drivers/usb/host/ehci-tegra.c:static struct of_device_id tegra_ehci_of_match[] __devinitdata = {
> drivers/usb/host/ehci-w90x900.c:static int __devinit usb_w90x900_probe(const struct hc_driver *driver,
> drivers/usb/host/ehci-w90x900.c:static int __devinit ehci_w90x900_probe(struct platform_device *pdev)
> drivers/usb/host/ehci-xilinx-of.c:static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
These drivers, when they are converted, will need a new ehci_*_init()
routine (separate from their probe routine) that calls
ehci_driver_init(). The new routine will be marked with __init and
will have a module_init() line.
This is the normal sort of thing that has to be done when converting a
driver to a standalone module. If you have a particular example you
can test, I'll write a patch to do the conversion.
> Other than that (and it might even be a stupid comment ;-), it looks
> good to me:
>
> Reviewed-by: Felipe Balbi <balbi@xxxxxx>
Thank you.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
