On Fri, 2 Nov 2012, Fengguang Wu wrote: > Hi Alan, > > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next > head: 99f91934a907df31ba878dfdd090002049dc476a > commit: 99f91934a907df31ba878dfdd090002049dc476a [89/89] USB: EHCI: make ehci-platform a separate driver > config: make ARCH=powerpc allmodconfig > > All error/warnings: > > In file included from drivers/usb/host/ehci-platform.c:28:0: > drivers/usb/host/ehci.h: In function 'ehci_readl': > drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be' [-Werror=implicit-function-declaration] > drivers/usb/host/ehci.h:663:3: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration] > drivers/usb/host/ehci.h: In function 'ehci_writel': > drivers/usb/host/ehci.h:674:3: error: implicit declaration of function 'writel_be' [-Werror=implicit-function-declaration] > drivers/usb/host/ehci.h:675:3: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors That was quick work! It's hard to know which headers are needed for foreign architectures. Still, I think this ought to fix the problems you found. Can you test this patch? Alan Stern Index: usb-3.7/drivers/usb/host/ehci-platform.c =================================================================== --- usb-3.7.orig/drivers/usb/host/ehci-platform.c +++ usb-3.7/drivers/usb/host/ehci-platform.c @@ -19,12 +19,16 @@ * Licensed under the GNU/GPL. See COPYING for details. */ #include <linux/kernel.h> +#include <linux/hrtimer.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/usb.h> #include <linux/usb/hcd.h> #include <linux/usb/ehci_pdriver.h> +#include <asm/byteorder.h> +#include <asm/io.h> + #include "ehci.h" #define DRIVER_DESC "EHCI generic platform driver" -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html