Hi Alan, FYI, kernel build failed on tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 99f91934a907df31ba878dfdd090002049dc476a commit: 99f91934a907df31ba878dfdd090002049dc476a [89/89] USB: EHCI: make ehci-platform a separate driver config: make ARCH=powerpc allmodconfig All error/warnings: In file included from drivers/usb/host/ehci-platform.c:28:0: drivers/usb/host/ehci.h: In function 'ehci_readl': drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be' [-Werror=implicit-function-declaration] drivers/usb/host/ehci.h:663:3: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration] drivers/usb/host/ehci.h: In function 'ehci_writel': drivers/usb/host/ehci.h:674:3: error: implicit declaration of function 'writel_be' [-Werror=implicit-function-declaration] drivers/usb/host/ehci.h:675:3: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors vim +662 +/readl_be drivers/usb/host/ehci.h 91bc4d31 Vladimir Barinov 2007-12-30 656 6dbd682b Stefan Roese 2007-05-01 657 static inline unsigned int ehci_readl(const struct ehci_hcd *ehci, 6dbd682b Stefan Roese 2007-05-01 658 __u32 __iomem * regs) 083522d7 Benjamin Herrenschmidt 2006-12-15 659 { d728e327 Benjamin Herrenschmidt 2006-12-28 660 #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO 083522d7 Benjamin Herrenschmidt 2006-12-15 661 return ehci_big_endian_mmio(ehci) ? 68f50e52 Al Viro 2007-02-09 @662 readl_be(regs) : 68f50e52 Al Viro 2007-02-09 @663 readl(regs); d728e327 Benjamin Herrenschmidt 2006-12-28 664 #else 68f50e52 Al Viro 2007-02-09 665 return readl(regs); d728e327 Benjamin Herrenschmidt 2006-12-28 666 #endif 083522d7 Benjamin Herrenschmidt 2006-12-15 667 } 083522d7 Benjamin Herrenschmidt 2006-12-15 668 6dbd682b Stefan Roese 2007-05-01 669 static inline void ehci_writel(const struct ehci_hcd *ehci, 6dbd682b Stefan Roese 2007-05-01 670 const unsigned int val, __u32 __iomem *regs) 083522d7 Benjamin Herrenschmidt 2006-12-15 671 { d728e327 Benjamin Herrenschmidt 2006-12-28 672 #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO 083522d7 Benjamin Herrenschmidt 2006-12-15 673 ehci_big_endian_mmio(ehci) ? 68f50e52 Al Viro 2007-02-09 @674 writel_be(val, regs) : 68f50e52 Al Viro 2007-02-09 @675 writel(val, regs); d728e327 Benjamin Herrenschmidt 2006-12-28 676 #else 68f50e52 Al Viro 2007-02-09 677 writel(val, regs); d728e327 Benjamin Herrenschmidt 2006-12-28 678 #endif --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html