Re: HDD spins up to slow for USB and/or Mass-Storage Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Oct 2012, Sarah Sharp wrote:

> On Fri, Oct 26, 2012 at 03:01:32PM -0700, Sarah Sharp wrote:
> > The USB core isn't dropping the endpoints before it calls
> > xhci_check_bandwidth.  I remember running into this bug a while back,
> > and I even started on a fix, but then couldn't reproduce the problem.
> > I found the branch with the old fix on it, but it still needs a bit of
> > work.  I'll send you a patch on Monday.
> 
> Matthias, can you try the attached patch?  You should be able to echo 1
> to the configuration file after this is applied.

It seems that this patch should go farther than it does.

Basically, what you are doing amounts to splitting
usb_hcd_alloc_bandwidth() up into two separate routines: one for
altsetting changes and one for config changes.  But that's not how the
new code is structured and as a result it ends up looking rather 
tortuous.

Also, I don't like the way we repeat that "find altsetting 0 or use the 
first altsetting" logic in several places.  We should have a single 
routine that determines which alternate interfaces will be installed as 
part of a new config.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux