Re: [PATCH] usbhid: use GFP_NOIO in reset code path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 12 Oct 2012, Ming Lei wrote:

> > Keeping allowed gfp_flag inside task_struct should be one solution, and
> > let that teach mm to allocate memory, see the draft idea below:
> >
> > diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c
> > index c0543c8..781447f 100644
> > --- a/drivers/usb/storage/transport.c
> > +++ b/drivers/usb/storage/transport.c
> > @@ -1329,11 +1329,13 @@ EXPORT_SYMBOL_GPL(usb_stor_Bulk_reset);
> >  int usb_stor_port_reset(struct us_data *us)
> >  {
> >         int result;
> > +       gfp_t orig_gfp = tsk_get_allowd_gfp(current);

Absolute and total nitpick: any reason for not calling it '_allowed_'? 
Let's try to make it friendly for random grepping.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux