Re: [PATCH] usbhid: use GFP_NOIO in reset code path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 10 October 2012 22:07:02 Ming Lei wrote:
> On Wed, Oct 10, 2012 at 8:20 PM, Oliver Neukum <oliver@xxxxxxxxxx> wrote:
> > For mice with card readers the HID driver can deadlock
> > as its post_reset() method allocates memory. GFP_NOIO
> > must be used in a block layer error handler, which
> > usbhid can be indirectly part of.
> 
> IMO, this kind of "fix" should be discussed further, because in theory
> we can't avoid all GFP_KERNEL allocation in both device
> reset path and runtime resume path, which may call other
> kernel component APIs with GFP_KERNEL allocation.

Which components? We generally don't do that. We may have
a problem with locks being held though.

> So hope to figure out one generic enough solution.

This is much harder than it sounds.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux