Re: [PATCH 00/24 v2] USB: OHCI and EHCI platform driver conversions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 4 Oct 2012, Florian Fainelli wrote:

> Hi all,
> 
> This patch series contains various EHCI and OHCI conversions as well as
> some cleanups in the existing OHCI HCD driver regarding suspend/resume
> as suggested by Alan Stern.
> 
> Changes since previous version summed up are:
> - improved various commit messages
> - changed the logic regarding need_io_watchdog
> - fixed arch/ files not using {e,o}hci-platform despite their "conversion"
> - updated more defconfigs
> - cleaned up OHCI HCD driver
> - dropped Octeon conversion per David Daney's request
> 
> Per-patch changes are detailed in the patches.

This is great stuff!  Thanks a lot for doing all this work.  A couple
of things still to be fixed (described in separate emails); nothing
very big.

One more request: How'd you like to convert ehci-platform.c and
ohci-platform.c to use devm_request_and_ioremap() for the memory
resources (like in the IXP4xx and Loongson files you removed)?  At the
same time you could fix the spelling of "resource" in the error
messages, and change all the pr_err() lines to dev_err().

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux