On Thu, 4 Oct 2012, Florian Fainelli wrote: > Since both the EHCI and OHCI platform drivers use the same power_{on,off} > callbacks, rename them to cns3xx_usb_power_{on,off} to show that they are > shared. This is an example of the sort of thing I complained about before. People who read only the patch description and not the title will wonder why this patch adds cns3xxx_usb_ohci_pdata and cns3xxx_usb_ohci_device. And people who read both will wonder why they talk about different things. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html