RE: [PATCH] usb: phy: tegra remove include of <mach/iomap.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx]
> Sent: Wednesday, October 03, 2012 4:20 AM
> To: Felipe Balbi
> Cc: Greg Kroah-Hartman; linux-usb@xxxxxxxxxxxxxxx; linux-
> tegra@xxxxxxxxxxxxxxx; Stephen Warren; Venu Byravarasu
> Subject: [PATCH] usb: phy: tegra remove include of <mach/iomap.h>
> 
> From: Stephen Warren <swarren@xxxxxxxxxx>
> 
> Almost nothing from this file is used, and the file will hopefully be
> deleted soon. Copy the tiny portions that are used directly into
> tegra_usb_phy.c. I believe that Venu Byravarasu is working on cleaning up
> our USB driver, and those cleanups will remove the need for these
> constants.
> 
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
> Cc: Venu Byravarasu <vbyravarasu@xxxxxxxxxx>
> ---
> Felipe, Greg, if this patch can get into 3.7 (it's late, I know) at a point
> before wherever you branch off your USB tree for 3.8, then that would be
> great. If not, may I please request this patch be merged into a separate
> branch/tag that is merged into both the Tegra and USB trees for 3.8, since
> I will probably have cleanup patches in the Tegra tree that depend on this
> change, and Venu will likely be sending patches through the USB tree that
> will need to be merged with this too.
> ---
>  drivers/usb/phy/tegra_usb_phy.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/phy/tegra_usb_phy.c
> b/drivers/usb/phy/tegra_usb_phy.c
> index 987116f..9d13c81 100644
> --- a/drivers/usb/phy/tegra_usb_phy.c
> +++ b/drivers/usb/phy/tegra_usb_phy.c
> @@ -29,7 +29,9 @@
>  #include <linux/usb/ulpi.h>
>  #include <asm/mach-types.h>
>  #include <linux/usb/tegra_usb_phy.h>
> -#include <mach/iomap.h>
> +
> +#define TEGRA_USB_BASE		0xC5000000
> +#define TEGRA_USB_SIZE		SZ_16K

This change looks fine to me. Plz consider my ACK.
Acked-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx> 

> 
>  #define ULPI_VIEWPORT		0x170
> 
> --
> 1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux