Re: [patch 1/2] target: remove duplicate initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-10-02 at 11:27 +0300, Dan Carpenter wrote:
> We set bAlternateSetting to zero twice.  I kept the second one
> (.bAlternateSetting = USB_G_ALT_INT_BBB) because that's more
> descriptive.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c
> index 0a83801..1ad4a69 100644
> --- a/drivers/usb/gadget/tcm_usb_gadget.c
> +++ b/drivers/usb/gadget/tcm_usb_gadget.c
> @@ -1956,7 +1956,6 @@ static void usbg_deregister_configfs(void)
>  static struct usb_interface_descriptor bot_intf_desc = {
>  	.bLength =              sizeof(bot_intf_desc),
>  	.bDescriptorType =      USB_DT_INTERFACE,
> -	.bAlternateSetting =	0,
>  	.bNumEndpoints =        2,
>  	.bAlternateSetting =	USB_G_ALT_INT_BBB,
>  	.bInterfaceClass =      USB_CLASS_MASS_STORAGE,
> --

Looks fine, applied to target-pending/for-next

Thanks Dan!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux