On Thu, 27 Sep 2012, Ming Lei wrote: > >> + pm_wakeup_event(&hdev->dev, 2000); > >> + return -EBUSY; > >> + } > >> + } > > > > The !PMSG_IS_AUTO case should not return -EBUSY, because > > usb_suspend_both() will ignore the return value. It should proceed > > with the rest of the suspend. > > That is a big problem wrt. this patch, :-( > > But as discussed in previous thread, usb_suspend_both() should return > failure and stop suspend for the situation, so that the wakeup event can > be handled asap. That can be done in a future patch. For now, you should change + return -EBUSY; to + else + return -EBUSY; Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
