Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Sep 24, 2012 at 02:53:24PM +0300, philippedeswert@xxxxxxxxx wrote:
> From: Philippe De Swert <philippe.deswert@xxxxxxxxxxxxxxx>
> 
> Unless generic_interrupt is defined the irq setup
> in musb_init_controller fails for the omap2430 driver
> since that one does not set it's own interrupt handler.
> Which leaves usb non-functional.
> 
> Tested on N950/N9.
> 
> Signed-off-by: Philippe De Swert <philippedeswert@xxxxxxxxx>

SoB's mail doesn't From mail.

> ---
>  drivers/usb/musb/musb_core.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index db3dff8..ff9e482 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1499,7 +1499,8 @@ static int __devinit musb_core_init(u16 musb_type, struct musb *musb)
>  /*-------------------------------------------------------------------------*/
>  
>  #if defined(CONFIG_SOC_OMAP2430) || defined(CONFIG_SOC_OMAP3430) || \
> -	defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_ARCH_U8500)
> +	defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_ARCH_U8500) || \
> +	defined(CONFIG_ARCH_OMAP2PLUS)

Weird, how can you build OMAP2PLUS without SOC_OMAPXXXX ??

BTW, this is also wrong as OMAP2PLUS is also used to enable AM3xxx and
TI8xxx, and those platforms don't use generic_interrupt().

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux