On Thursday 20 September 2012 16:26:18 Ming Lei wrote: > On Thu, Sep 20, 2012 at 3:29 PM, Oliver Neukum <oneukum@xxxxxxx> wrote: > > On Thursday 20 September 2012 13:28:51 Ming Lei wrote: > >> If one usb interface driver returns failure from its > >> suspend(auto) callback inside usb_suspend_both, its > >> resume() callback should be called to recover its > >> working state. > > > > NO! > > > > The interface is defined so that if you fail, this is your > > problem. You cannot simply change the API. This patch > > is absolutely wrong. > > Sorry, you are right, it is my fault, :-( No problem, that is why we review patches. And writing innovative patches means that some patches wil have fundamental problems. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html