> -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Wednesday, September 19, 2012 2:27 PM > To: Mehresh Ramneek-B31383 > Cc: linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] fsl/usb: Add support for USB controller version 2.4 > > On Wed, Sep 19, 2012 at 02:18:45PM +0530, Ramneek Mehresh wrote: > > Add support for USB controller version 2.4 > > > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> > > --- > > Applies on > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > (branch usb-next) > > > > drivers/usb/host/fsl-mph-dr-of.c | 2 ++ > > include/linux/fsl_devices.h | 1 + > > 2 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/usb/host/fsl-mph-dr-of.c > > b/drivers/usb/host/fsl-mph-dr-of.c > > index 22ff6b3..1e77129 100644 > > --- a/drivers/usb/host/fsl-mph-dr-of.c > > +++ b/drivers/usb/host/fsl-mph-dr-of.c > > @@ -133,6 +133,8 @@ static int usb_get_ver_info(struct device_node *np) > > ver = FSL_USB_VER_1_6; > > else if (of_device_is_compatible(np, "fsl-usb2-dr-v2.2")) > > ver = FSL_USB_VER_2_2; > > + else if (of_device_is_compatible(np, "fsl-usb2-dr-v2.4")) > > + ver = FSL_USB_VER_2_4; > > What is going to happen for the next version? Why do you need to check > this for every new release of this chip? You aren't doing anything with > this check that I can see, so it seems kind of pointless, and you will > constantly be "behind" the hardware curve, right? > > In other words, why not just rip this out entirely, and only care about > any version that might cause problems for known old chips? > > thanks, > > greg k-h This version info is updated into pdata->controller_ver using usb_get_ver_info(). pdata->controller_ver is used to identify the controller version, and later is used for initialization in different ways in the ehci driver if (pdata->controller_ver) { /* controller version 1.6 or above */ ... } portsc |= PORT_PTS_ULPI; break; anyways...we have come to know that we won't have anymore controller version... of the same family. Also, there are multiple versions of older controller, and they'll also have to be added almost in the same way... -ramneek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
