Hello Sebastian,
On September 17, 2012 6:15 PM Sebastian Andrzej Siewior wrote:
<snip>
> >--- a/drivers/usb/gadget/storage_common.c
> >+++ b/drivers/usb/gadget/storage_common.c
> >@@ -321,7 +507,7 @@ enum {
> > #ifndef FSG_NO_OTG
> > static struct usb_otg_descriptor
> > fsg_otg_desc = {
> >- .bLength = sizeof fsg_otg_desc,
> >+ .bLength = sizeof(fsg_otg_desc),
> > .bDescriptorType = USB_DT_OTG,
> >
> > .bmAttributes = USB_OTG_SRP,
>
> and this coding style fixup which does not belong in here as well.
> Please remove that nonsense from your patch before posting.
>
I don't like it either. Checkpatch started complaining about
sizeof <something> in favor of sizeof(<something>).
<snip>
> This patch ends with
> |+#include "f_mass_storage.c"
>
> This is no good. I'm going to remove that include statement from current
> gadgets in tree. But don't complain because I'm going to make the life
> easier for you and this patch even smaller :) What you will get from me is
> a function which gives you pointer to something that describes a function
> and maybe something that configures it (including luns and ...). Not sure
> yet.
Right. But as of now, it exists. I had to use f_mass_storage.c somehow
for this RFC. And it's just that. By no means do I insist on continuing
the "#include .c" approach.
AP
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
