On Wed, Sep 12, 2012 at 01:39:01PM +0300, Heikki Krogerus wrote: > Hi, > > On Tue, Aug 28, 2012 at 03:03:12PM +0800, Richard Zhao wrote: > > +static int mxs_phy_set_host(struct usb_otg *otg, struct usb_bus *host) > > +{ > > Shouldn't you at least save the host pointer? > > otg->host = host; It looks making sense, though it's not called by chipidea driver. > > > + return 0; > > +} > > + > > +static int mxs_phy_set_peripheral(struct usb_otg *otg, > > + struct usb_gadget *gadget) > > +{ > > And the same with the gadget? Thanks Richard > > > + return 0; > > +} > > -- > heikki > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html