Re: [PATCHv3] usb: dwc3: use a burst size only ss-mode

[Sergei Shtylyov <sshtylyov@xxxxxxxxxx>]

Hello.

On 08/31/2012 08:42 AM, Chanho Park wrote:

> When connection is established non-ss mode,
                                ^ "in" missing

> a maxburst is set to 0.
> Therefore, the value of burst size has wrong value. We must use the burst size

   Value has value?

> only in ss-mode.

   What is ss-mode anyway? SuperSpeed mode?

> Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/usb/dwc3/gadget.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 58fdfad..440a86b 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -434,12 +434,16 @@ static int dwc3_gadget_set_ep_config(struct dwc3 *dwc, struct dwc3_ep *dep,
>  		const struct usb_ss_ep_comp_descriptor *comp_desc)
>  {
>  	struct dwc3_gadget_ep_cmd_params params;
> +	u32 burst_size;
>  
>  	memset(&params, 0x00, sizeof(params));
>  
> +	/* We only use a burst size in ss-mode */
> +	burst_size = (com_desc) ? (dep->endpoint.maxburst - 1) : 0;

   No parens needed around the operands of ?: operator.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html