Dear Fabio Estevam, > Hi Marek, > > On Thu, Aug 30, 2012 at 12:20 PM, Marek Vasut <marex@xxxxxxx> wrote: > >> +#define MXY_PHY_ENHOSTDISCONDETECT_DELAY 250 > >> + > > > > Why 250 <what unit?> ? :) > > It is 250 ms. We found this one to be a safe value to enable > ENHOSTDISCONDETECT in our tests. Documentation / comment would be handy ... but why 250mS and not 500mS for example? Cant it get racy here? > >> + /* > >> + * Delay enabling ENHOSTDISCONDETECT so that connection and > >> + * reset processing can be completed for the root hub. > >> + */ > >> + dev_dbg(phy->dev, "Delaying setting ENHOSTDISCONDETECT\n"); > >> + PREPARE_DELAYED_WORK(&mxs_phy->enhostdiscondetect_work, > >> + mxs_phy_enhostdiscondetect_delay); > >> + schedule_delayed_work(&mxs_phy->enhostdiscondetect_work, > >> + > >> msecs_to_jiffies(MXY_PHY_ENHOSTDISCONDETECT_DELAY)); > > > > Isn't this mx23 specific? > > Checked with Peter Chen and also the design team confirmed that the > mxs phy block is the same on mx23/mx28/mx6q. > > Regards, > > Fabio Estevam Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
