Re: [PATCH 1/2] usb: otg: mxs-phy: Fix mx23 operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

On Thu, Aug 30, 2012 at 12:20 PM, Marek Vasut <marex@xxxxxxx> wrote:
>
>> +#define MXY_PHY_ENHOSTDISCONDETECT_DELAY     250
>> +
>
> Why 250 <what unit?> ? :)

It is 250 ms. We found this one to be a safe value to enable
ENHOSTDISCONDETECT in our tests.

>> +     /*
>> +      * Delay enabling ENHOSTDISCONDETECT so that connection and
>> +      * reset processing can be completed for the root hub.
>> +      */
>> +     dev_dbg(phy->dev, "Delaying setting ENHOSTDISCONDETECT\n");
>> +     PREPARE_DELAYED_WORK(&mxs_phy->enhostdiscondetect_work,
>> +                     mxs_phy_enhostdiscondetect_delay);
>> +     schedule_delayed_work(&mxs_phy->enhostdiscondetect_work,
>> +                     msecs_to_jiffies(MXY_PHY_ENHOSTDISCONDETECT_DELAY));
>
> Isn't this mx23 specific?

Checked with Peter Chen and also the design team confirmed that the
mxs phy block is the same on mx23/mx28/mx6q.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux