On 2012年08月29日 23:36, Alan Stern wrote: > On Wed, 29 Aug 2012, Lan Tianyu wrote: > >> Hi Alan: >> Do you have some advices on this patch? I current have two proposals. >> 1) Add a new routine to get port connection before port's device being >> created and being bound with ACPI. The routine first need to get port's acpi >> handle and then get connection information. The routine doesn't save port's acpi >> handle. >> 2) keep my current code except the second time of getting hub descriptor, >> Set DeviceRemovable in the hub_configue() after ports' device being created. >> Looking forward for your comments. Thanks. > > Even though 2) would be simpler, I think 1) would be a better approach. > The new routine could be called by register_root_hub() in hcd.c, and > the connection information could be stored in the hcd's usb_bus > structure. Then ehci_hub_descriptor() could get the information from > there. OK. This can resolve the root hub problems. And this let me think of the same problem for non-root hub on the motherboard(e.g ehci has integrated hub under root hub). Their ports also have acpi information. I think we also need to find some place to set DeviceRemovable for them and power resource should be at the integrated hub ports because the usb devices are acctually attached to them. right? > > Alan Stern > -- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
