Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 29 Aug 2012, Lan Tianyu wrote:

> Hi Alan:
> 	Do you have some advices on this patch? I current have two proposals.
> 	1) Add a new routine to get port connection before port's device being
> created and being bound with ACPI. The routine first need to get port's acpi
> handle and then get connection information. The routine doesn't save port's acpi
> handle.
> 	2) keep my current code except the second time of getting hub descriptor,
> Set DeviceRemovable in the hub_configue() after ports' device being created.
> 	Looking forward for your comments. Thanks.

Even though 2) would be simpler, I think 1) would be a better approach.  
The new routine could be called by register_root_hub() in hcd.c, and 
the connection information could be stored in the hcd's usb_bus 
structure.  Then ehci_hub_descriptor() could get the information from 
there.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux