Re: [PATCH 3/3] usb/gadgets: push iSerialNumber into gadgets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>> --- a/include/linux/usb/composite.h
>>> +++ b/include/linux/usb/composite.h
>>> @@ -398,6 +398,7 @@ struct usb_composite_overwrite {
>>>   	u16	idVendor;
>>>   	u16	idProduct;
>>>   	u16	bcdDevice;
>>> +	char	*iSerialNumber;

> On 08/28/2012 11:54 PM, Michal Nazarewicz wrote:
>> There was this comment a while back that the name does not really match
>> USB specification as “i” should be an index and not a string, so even
>> though we're stuck with iSerialNumber as module parameter, maybe it
>> would make sense to rename it here?

Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes:
> very good then. So just cut the i and stick with serial_number?

Yeah, I think that's exquisite name
.
-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--

Attachment: pgp1qwx24_NzU.pgp
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux