* Michal Nazarewicz | 2012-08-24 19:09:06 [+0200]:
>Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes:
>> This patch removes the global variable usb_composite_driver() in
>
>s/()//, otherwise it looks like a function name. :)
fixed in v3.
>> @@ -1401,7 +1401,7 @@ static int udc_wakeup(struct usb_gadget *gadget)
>> index 29d5f70..598df69 100644
>> --- a/drivers/usb/gadget/composite.c
>> +++ b/drivers/usb/gadget/composite.c
>> * String parameters are in UTF-8 (superset of ASCII's 7 bit characters).
>> @@ -889,6 +887,7 @@ static int lookup_string(
>> static int get_string(struct usb_composite_dev *cdev,
>> void *buf, u16 language, int id)
>> {
>> + struct usb_composite_driver *cdriver = cdev->driver;
>
>Should you keep the ???composite??? name for the variable, the rest of the
>patch would be a bit shorter. :)
Seriously? I have it now consistent within the file. The second series
which little large would clash here. I would prefer to avoid this if
possible.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
