Re: [PATCH 7/7 v2] usb/gadget: remove global struct usb_composite_driver in composite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 Aug 2012, Sebastian Andrzej Siewior wrote:

> This patch removes the global variable usb_composite_driver() in
> composite.c. The private data which was saved there is now passed via
> an additional argument to the bind() function in struct
> usb_gadget_driver.
> 
> Only the "old-style" UDC drivers have to be touched here, new style are
> doing it right because this change is made in udc-core.

Much better, thank you.  Except that the global variable is named
"composite", not "usb_composite_driver", and it is a pointer to a
usb_composite_driver structure, not a function.

> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -31,8 +31,6 @@
>  /* big enough to hold our biggest descriptor */
>  #define USB_BUFSIZ	1024
>  
> -static struct usb_composite_driver *composite;

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux