Hi,
Le 23/08/2012 09:23, Oliver Neukum a écrit :
> On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:
>> +static int ebeam_resume(struct usb_interface *intf)
>> +{
>> + struct ebeam_device *ebeam = usb_get_intfdata(intf);
>> + struct input_dev *input = ebeam->input;
>> + int result = 0;
>> +
>> + mutex_lock(&input->mutex);
>> + if (input->users)
>> + result = usb_submit_urb(ebeam->irq, GFP_NOIO);
>> + mutex_unlock(&input->mutex);
>> +
>> + return result;
>> +}
>> +
>> +static int ebeam_reset_resume(struct usb_interface *intf)
>> +{
>> + struct ebeam_device *ebeam = usb_get_intfdata(intf);
>> + struct input_dev *input = ebeam->input;
>> + int err = 0;
>> +
>> + /* restart IO if needed */
>> + mutex_lock(&input->mutex);
>> + if (input->users)
>> + err = usb_submit_urb(ebeam->irq, GFP_NOIO);
>> + mutex_unlock(&input->mutex);
>> +
>> + return err;
>> +}
>
> These functions are identical. You should unify them.
Removed reset_resume from the driver (optional, and not needed
for this hardware).
Thanks.
--
Yann Cantin
A4FEB47F
--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
