Re: [PATCH] tusb6010: fix error path in tusb_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Aug 20, 2012 at 10:31:41PM +0400, Sergei Shtylyov wrote:
> On platform_device_add() failure, the TUSB6010 glue layer forgets to call
> platform_device_put() -- probably due to a typo...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

wow.. I was just fixing this same issue today. Creepy. Will apply your
patch :-)

> ---
> This patch is atop of 'musb' branch of Felipe's tree...
> 
>  drivers/usb/musb/tusb6010.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: usb/drivers/usb/musb/tusb6010.c
> ===================================================================
> --- usb.orig/drivers/usb/musb/tusb6010.c
> +++ usb/drivers/usb/musb/tusb6010.c
> @@ -1199,7 +1199,7 @@ static int __devinit tusb_probe(struct p
>  	ret = platform_device_add(musb);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to register musb device\n");
> -		goto err1;
> +		goto err2;
>  	}
>  
>  	return 0;

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux