On 08/19/2012 02:33 PM, Roland Stigge wrote:
On 17/08/12 11:42, Sebastian Andrzej Siewior wrote:
Some minor things:
- please use to_udc() in start then
- would it make sense to use platform_get_drvdata() in
lpc32xx_udc_shutdown() ?
- could you please remove struct usb_endpoint_descriptor from struct
lpc32xx_ep? It has been removed a while back from other drivers.
I merged these changes into the patch set, and will repost it tomorrow
after I can test it more thoroughly.
Thanks.
While you are playing with it, I saw that you handle vbus (->pull())
manually. This was the case in the "old" start/stop case but in the new
one, the udc-core is / should handle it.
Thanks,
Roland
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
