On Wed, Aug 15, 2012 at 10:29:50AM +0800, Lan Tianyu wrote: > On 2012年08月15日 08:28, Greg Kroah-Hartman wrote: > > On Tue, Jul 17, 2012 at 03:28:43PM -0700, Sarah Sharp wrote: > >> --- a/drivers/usb/core/usb.h > >> +++ b/drivers/usb/core/usb.h > >> @@ -1,5 +1,9 @@ > >> #include <linux/pm.h> > >> > >> +#ifdef CONFIG_ACPI > >> +#include <linux/acpi.h> > >> +#endif > > > > Why is this #ifdef in here? > > > If CONFIG_ACPI was not defined, the header file would be useless. So add > #ifdef. Do this make sense? No, why not just always include it? A header file should not break the build if the config option is not enabled, right? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
