On Tue, Aug 14, 2012 at 10:40:21AM +0800, Chen Peter-B29397 wrote: > > > > > > According to IC guys, the logic of handling HOSTDISCONDETECT is the > > same > > > between i.mx28 and i.mx23. > > > > As pointed out by Sean, on mx23 reference manual we have the following > > text describing HOSTDISCONDETECT: > > > > "Due to a on chip issue (Errata #2791), software must > > pay attention to when to assert the HOSTDISCONDETECT bit description > > has the following: > > > > ENHOSTDISCONDETECT bit in HW_USBPHY_CTRL register: > > 1. Only set HW_USBPHY_CTRL.ENHOSTDISCONDETECT > > during high speed host mode. > > 2. Do not set HW_USBPHY_CTRL.ENHOSTDISCONDETECT > > during the reset and speed negotiation period. > > 3. Do not set HW_USBPHY_CTRL.ENHOSTDISCONDETECT > > during host suspend/resume sequence." > > > > and the same is not present on mx28 reference manual. > > > > How can we make sure we are not violating the point 2 above? > > > It is the same with i.mx28. If they're same, imx23 should be ok. The mxs_phy driver pass test on mx28. > I think Richard's patch should not > violate point 2. Richard, can you confirm it? You mean I should not set the bit in mxs_phy_on_connect? or mxs_phy_on_connect is called in wrong place? Thanks Richard > > > Thanks, > > > > Fabio Estevam > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
