Hi Simon Thank you for checking patch > > +#define ehci_pdata_get(pdata, x) ((pdata) ? (pdata)->x : 0) > > + > > FWIW, I think that an inline function would be a slight improvement over > a macro here. Likewise for the 2nd patch of this series. All these patches have this kind of macros. I needs maintainer's opinion. If he said it should be inline, I'm happy to send v4 patches. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html