Dear Chen Peter-B29397,
> > Which one? The MX28 p-o-s? Skimming through it's sources, I already used
> > two
> > puking bags, more to be filled tho.
>
> mx23,mx28, maybe mx6x is the same.
I use the MX28, so I made these two patches (follow). I'll roll them into an
official thingie and submit properly, but I'd like to know Greg's opinion first.
First patch is the obvious increment, but I also need the second one which adds
quirk for the MX28 bootrom. If you issue such command to it, the bootrom
crashes, therefore the quirk.
With these in place, I can get some output from the bootrom finally using
libusb.
Greg, can you please take an experienced look on these (and avoid tearing me
limb to limb because I didn't submit them properly ;-) ) and tell me your
opinion?
Thanks!
------>8------
--- a/drivers/hid/hid-core.c 2012-08-04 23:53:38.900126160 +0200
+++ b/drivers/hid/hid-core.c 2012-08-04 23:54:03.148127188 +0200
@@ -374,7 +374,7 @@
case HID_GLOBAL_ITEM_TAG_REPORT_SIZE:
parser->global.report_size = item_udata(item);
- if (parser->global.report_size > 96) {
+ if (parser->global.report_size > 128) {
hid_err(parser->device, "invalid report_size %d\n",
parser->global.report_size);
return -1;
------8<------
--- a/drivers/hid/usbhid/hid-quirks.c 2012-08-05 02:58:15.880274023 +0200
+++ b/drivers/hid/usbhid/hid-quirks.c 2012-08-05 02:58:10.228273782 +0200
@@ -99,6 +99,7 @@
{ USB_VENDOR_ID_SIGMA_MICRO, USB_DEVICE_ID_SIGMA_MICRO_KEYBOARD,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_MOUSEPEN_I608X,
HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M610X,
HID_QUIRK_MULTI_INPUT },
+ { USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, HID_QUIRK_NOGET
},
{ 0, 0 }
};
--- a/drivers/hid/hid-ids.h 2012-08-05 02:59:00.340275908 +0200
+++ b/drivers/hid/hid-ids.h 2012-08-05 02:58:56.008275723 +0200
@@ -282,6 +282,9 @@
#define USB_VENDOR_ID_EZKEY 0x0518
#define USB_DEVICE_ID_BTC_8193 0x0002
+#define USB_VENDOR_ID_FREESCALE 0x15A2
+#define USB_DEVICE_ID_FREESCALE_MX28 0x004F
+
#define USB_VENDOR_ID_FRUCTEL 0x25B6
#define USB_DEVICE_ID_GAMETEL_MT_MODE 0x0002
------>8------
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
