Hi Bhupesh,
Thanks for the patch.
On Thursday 26 July 2012 10:42:50 Bhupesh Sharma wrote:
> As per UVC compliance test specification's assertion number 6.3.90
> related to 'Standard VS Isochronous Video Data Endpoint Descriptor
> Assertions', the bits D3..2 of 'bmAttributes' field of Standard VS
> Isochronous Video Data Endpoint Descriptor should be 01 (binary) to
> indicate that the synchronization type is ASYNCHRONOUS.
>
> This mandatory requirement has been captured in section 3.10.1.1 of the UVC
> Video Class Specification version 1.1
>
> This patch adds a fix for the same.
>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxx>
With the indentation fixed,
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
I've added the patch to my tree, rebased on top of my cleanup patches. There's
no need to resubmit it.
> ---
> drivers/usb/gadget/f_uvc.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget/f_uvc.c
> index 70fa610..4ef386a 100644
> --- a/drivers/usb/gadget/f_uvc.c
> +++ b/drivers/usb/gadget/f_uvc.c
> @@ -147,7 +147,8 @@ static struct usb_endpoint_descriptor
> uvc_fs_streaming_ep = { .bLength = USB_DT_ENDPOINT_SIZE,
> .bDescriptorType = USB_DT_ENDPOINT,
> .bEndpointAddress = USB_DIR_IN,
> - .bmAttributes = USB_ENDPOINT_XFER_ISOC,
> + .bmAttributes = USB_ENDPOINT_SYNC_ASYNC |
> + USB_ENDPOINT_XFER_ISOC,
> .wMaxPacketSize = cpu_to_le16(512),
> .bInterval = 1,
> };
> @@ -156,7 +157,8 @@ static struct usb_endpoint_descriptor
> uvc_hs_streaming_ep = { .bLength = USB_DT_ENDPOINT_SIZE,
> .bDescriptorType = USB_DT_ENDPOINT,
> .bEndpointAddress = USB_DIR_IN,
> - .bmAttributes = USB_ENDPOINT_XFER_ISOC,
> + .bmAttributes = USB_ENDPOINT_SYNC_ASYNC |
> + USB_ENDPOINT_XFER_ISOC,
> .wMaxPacketSize = cpu_to_le16(1024),
> .bInterval = 1,
> };
> @@ -187,7 +189,8 @@ static struct usb_endpoint_descriptor
> uvc_ss_streaming_ep __initdata = { .bDescriptorType = USB_DT_ENDPOINT,
>
> .bEndpointAddress = USB_DIR_IN,
> - .bmAttributes = USB_ENDPOINT_XFER_ISOC,
> + .bmAttributes = USB_ENDPOINT_SYNC_ASYNC |
> + USB_ENDPOINT_XFER_ISOC,
> .wMaxPacketSize = cpu_to_le16(1024),
> .bInterval = 4,
> };
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
