> From: Ido Shayevitz [mailto:idos@xxxxxxxxxxxxxx] > Sent: Wednesday, August 01, 2012 7:25 AM > > On Mon, July 30, 2012 12:00 pm, Paul Zimmerman wrote: > >> From: Ido Shayevitz [mailto:idos@xxxxxxxxxxxxxx] > >> Sent: Monday, July 30, 2012 3:15 AM > >> > >> If the USB_DWC3 is not selected then even dwc3/core.c is not being built > >> and core.c supports also non DRD cores (depends on DWC3_MODE), so we > >> want > >> to build the DWC3 if there is at least host support or a gadget support. > >> In case that the DWC_MODE is DRD but USB is not on, then dwc3/host.c > >> will > >> add the xHCI device, but will be no xHCI driver (xhci-plat) that will > >> probe on this device. > > > > I just tried compiling this without USB_GADGET defined, and I get > > these errors: > > > > HOSTCC arch/x86/boot/compressed/mkpiggy > > ERROR: "usb_gadget_map_request" [drivers/usb/dwc3/dwc3.ko] undefined! > > ERROR: "usb_del_gadget_udc" [drivers/usb/dwc3/dwc3.ko] undefined! > > ERROR: "usb_gadget_unmap_request" [drivers/usb/dwc3/dwc3.ko] undefined! > > ERROR: "usb_add_gadget_udc" [drivers/usb/dwc3/dwc3.ko] undefined! > > > > Yes, you are totally right. > So we have two options: The first is, if you agree with my reasoning: > "and core.c supports also non DRD cores (depends on DWC3_MODE), so we want > to build the DWC3 if there is at least host support or a gadget support." > Then we may want to build gadget.c and ep0.c only if USB_GADGET is > selected and this requires also changes in core.c or core.h (providing > empty prototype for dwc3_gadget_init() ?) > > The second option is indeed to keep it as it is, means USB && USB_GADGET. > It means that kernel image size will have to include xHCI driver and dwc3 > gadget driver, nevertheless if the controller is DRD or not. > Basically I am ok with that too. > > Please let me know what you and Felipe decide... Well, it's up to Felipe to decide, he's the maintainer. If it was me, I would keep it as USB && USB_GADGET for now. Making it work with just one of them set should be done in a future patch. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
