On 2012/7/31 22:39, Alan Stern wrote:
On Tue, 31 Jul 2012, Lan Tianyu wrote:
How about checking RESET_MORPHS before doing reset_resume, set reset_resume
to 0 and do resume when RESET_MORPHS is set.
No, that won't work. When we do a reset-resume it is because we _know_
that a regular resume will fail.
persist is default to be enabled. When user space set a device's
avoid_reset_quirk, they also should set persist to 0. Since these
devices can be reset and regular resume can work. Right?
At the same time, print "Convert
reset_resume to resume due to RESET_MORPHS". Then these two attributes are
separated but for reset-resume, there are two conditions. persist is true
RESET_MORPHS is unset.
I think the best course is to leave things the way they are. Just add
an explanation to persist.txt that the Persist mechanism is likely to
fail if the avoid_reset_quirk attribute is set.
If we leave things the way they are, do we still need previous patch
"Take attribute avoid_reset_quirk out of usb device's attribute group"?
Alan Stern
--
Best Regards
Tianyu Lan
linux kernel enabling team
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
