RE: [PATCH 0/6] UVC gadget cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thanks for the patchset.

> -----Original Message-----
> From: Laurent Pinchart [mailto:laurent.pinchart@xxxxxxxxxxxxxxxx]
> Sent: Wednesday, August 01, 2012 6:27 PM
> To: linux-usb@xxxxxxxxxxxxxxx
> Cc: Bhupesh SHARMA
> Subject: [PATCH 0/6] UVC gadget cleanup
> 
> Hi,
> 
> These 6 patches clean up the UVC gadget driver after Bhupesh Sharma's
> "UVC
> webcam gadget related changes" patch series. They're what I would have
> asked
> during patch review if the original patches hadn't been merged before I
> got a
> change to review them.
> 
> Bhupesh, would you mind testing the patches, especially the ones that
> touch
> super speed support ? I have no SS hardware I can test them on.

Sure. I will get back with my test results.
But I noticed that this patchset touches a enumeration issue I already
addressed in my patchest [PATCH 0/3] Fixes for UVC test suite (available in USBCV) failures
available here: http://www.spinics.net/lists/linux-usb/msg68011.html

This patchset is awaiting your comments.
After my test finding, please make sure to rebase your patches over this patchset.

Regards,
Bhupesh


> Laurent Pinchart (6):
>   usb: gadget/uvc: Clarify comment about string descriptors
>   usb: gadget/uvc: Rename STATUS_BYTECOUNT to
>     UVC_STATUS_MAX_PACKET_SIZE
>   usb: gadget/uvc: Fix coding style issues introduced by SS support
>   usb: gadget/uvc: Merge the SS/HS/FS status endpoint descriptors
>   usb: gadget/uvc: Merge the streaming maxpacket and mult parameters
>   usb: gadget/uvc: Configure the streaming endpoint based on the speed
> 
>  drivers/usb/gadget/f_uvc.c |  220 +++++++++++++++++++++---------------
> --------
>  drivers/usb/gadget/f_uvc.h |   12 +-
>  2 files changed, 110 insertions(+), 122 deletions(-)
> 
> --
> Regards,
> 
> Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux