Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 31 July 2012 16:54:13 Bjørn Mork wrote:
> Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
> > On Tue, 31 Jul 2012, Bjørn Mork wrote:
> >
> >> IMHO that should have been the default for any composite device, but
> >> whatever..  I don't think it's very nice of usb-storage to reset the
> >> device if there are drivers bound to other functions.
> >
> > That's why we have pre_reset and post_reset callbacks.  The alternative 
> > is to lose access to all the mounted filesystems on the mass-storage 
> > device, which isn't very nice either.
> 
> Well, you are then saying that usb-storage has priority over any other
> function and that is often wrong IMHO.  There are many newer composite
> devices where the usb-storage function is thrown in as a bonus most
> users never will touch, where the main function can be modem or printer
> or whatever.  Letting the usb-storage driver reset these devices is bad.
> 
> Ref for example http://comments.gmane.org/gmane.linux.usb.general/60055

User space can set the quirk. It wasn't intended for this, but it does the
job. Furthermore on such devices, storage could be a bot more cooperative
and try the class specific reset first.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux