Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 30 July 2012 17:03:27 Alan Stern wrote:
> On Mon, 30 Jul 2012, Sarah Sharp wrote:

> I'm not even sure that RESET_MORPHS is the right thing to look at here.  
> It's possible for a device to retain important settings across a reset
> but lose them when power is removed.

True. So an additional quirk? QUIRK_FIRMWARE_VOLATILE?

[..]
> >    2. If the device is internal and suspended, power off the port if all
> >       the following are true:
> > 
> >       a) all interface drivers have supports_power_off set, or no
> > 	 interface drivers are bound and usbfs has not claimed the
> > 	 device.
> >       b) remote wakeup is disabled
> >       c) USB_QUIRK_RESET_MORPHS is not set
> > 
> >  - If userspace wants a port to be powered off, and one of the interface
> >    drivers doesn't set supports_power_off or the driver enables remote
> >    wakeup, then userspace will need to unbind or unload the driver.
> 
> Like other people, I'm dubious about these conditions.

Can you propose other conditions?

> I tend to agree that having the kernel make these decisions is fraught 
> with difficulties, except in the most simple cases (unpluggable and no 
> device present).

Yes.
 
> Exposing the extra attributes to userspace can't hurt -- unless we want 
> to change or remove them in the future!

These are two different things.

The attributes are defined by ACPI. We have little say in how they would look
like. But the API for controlling power off is an open question.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux