On 2012年07月31日 04:00, Sarah Sharp wrote:
On Mon, Jul 30, 2012 at 09:28:36AM +0200, Oliver Neukum wrote:
On Monday 30 July 2012 11:34:10 Lan Tianyu wrote:
The hub is always supposed to support reset and its persist is enabled.
By default, not necessarily always. User space may disable it.
So hub doesn't need attribute avoid_reset_quirk. The patch is to take
attribute avoid_reset_quirk out of usb device's attribute group and
add or remove it in the usb_create/remove_sysfs_dev_files() if the device
is not a usb hub.
Why? What is gained doing so? Without further explanation about the need
or benefit of doing so, why do you want to make hubs different from
other devices?
Along those lines, Tianyu, can you share what your master plan for
implementing the automatic powering off of ports? I think it would help
to understand the bigger picture when looking at small patches like
these.
hi sarah:
These patches are trying to prevent reset-resume after avoid_reset_
quirk being set and maybe less related with automatic power off of ports.
Last discussion, Oliver mentions USB_QUIRK_RESET_MORPHS should be considered.
So I read code and find that the flag can't prevent reset-resume. And then
produced these patch. About automatic powering off, I will send a RFC patch
for discussion.
--
Best Regards
Tianyu Lan
linux kernel enabling team
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
