RE: usb : mass storage : short_not_ok for non usb3 udc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 26 Jul 2012, Paul Zimmerman wrote:

> > That's very clear.  So Rajaram, when you redo the patch you can simply
> > leave out the checks for SuperSpeed.  Set or clear the short_not_ok
> > flag depending only on the size of the bulk transfer, regardless of the
> > speed.
> 
> I have a bit of a philosophical problem with that. At SuperSpeed, a short
> packet has to be OK, because of the way the mass-storage protocol works.
> So it seems wrong to set short_not_ok for SuperSpeed when we know we
> will be receiving short packets.
> 
> But I guess practicality trumps philosophy :)

Hmmm.  I suppose an impartial approach would be to set short_not_ok 
only when the blocksize >= the maxpacket size.  That should always work 
as a general rule, regardless of speed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux