On Wed, 25 Jul 2012, Paul Zimmerman wrote: > > > > I don't understand this either. What's wrong with setting > > > > short_not_ok while at SuperSpeed? It shouldn't force the use of a > > bounce buffer. > > > > > > > > > > I have just brought back some code removed by patch "usb: fix mass > > > storage gadgets to work with Synopsys UDC". > > > > Maybe while bringing it back you can remove the checks for SuperSpeed. > > Is there any reason to keep them? > > Hi Alan, > > The problem only arises because at super-speed the MaxPacket size is > 1024, which is greater than the sector size of 512. So the whole point of > the patch is to fix the SuperSpeed operation, while allowing high-speed > devices to operate as they always did. Don't the mass-storage drivers already operate correctly at SuperSpeed? If not, what goes wrong? Besides, how could the patch possibly affect SuperSpeed operation? Everything it does is protected by if (!gadget_is_superspeed(gadget)) So I'm afraid I don't understand your point. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
