Re: [PATCHv2 2/2] ARM: vt8500: Add support for UHCI companion controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 20 July 2012, Tony Prisk wrote:
> Add support for a generic non-pci UHCI companion controller.
> Existing board files for arch-vt8500 updated to include UHCI
> support.
> 
> Signed-off-by: Tony Prisk <linux@xxxxxxxxxxxxxxx>

Looks almost good, but 

* please add a binding document
* cc the maintainers and usb mailing list
* the "of-uhci" string does not seem appropriate:

> +static const struct of_device_id platform_uhci_ids[] = {
> +	{ .compatible = "of-uhci", },
> +	{}
> +};

The of- part is clearly meaningless in the binding that is about of
devices. Using usb-uhci would be more appropriate I think, but maybe
someone can come up with an even better name. Which consortium
or company created uhci?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux