> -----Original Message----- > From: Sebastian Andrzej Siewior [mailto:bigeasy@xxxxxxxxxxxxx] > Sent: quinta-feira, 19 de Julho de 2012 18:11 > To: Felipe Balbi > Cc: Greg Kroah-Hartman; linux-usb@xxxxxxxxxxxxxxx; Mario Jorge Isidoro; Fabio > Porcedda; sebastian@xxxxxxxxxxxxx; Sebastian Andrzej Siewior > Subject: [PATCH 1/2] usb/at91udc: don't overwrite driver data > > The driver was converted to the new start/stop interface in f3d8bf34c2 > ("usb: gadget: at91_udc: convert to new style start/stop interface"). > I overlooked that the driver is overwritting the private data which is > used by the composite framework. The udc driver doesn't read it, it is > only writen here > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > --- > drivers/usb/gadget/at91_udc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c > index 1a4430f..5fd61e2 100644 > --- a/drivers/usb/gadget/at91_udc.c > +++ b/drivers/usb/gadget/at91_udc.c > @@ -1634,7 +1634,6 @@ static int at91_start(struct usb_gadget *gadget, > udc = container_of(gadget, struct at91_udc, gadget); > udc->driver = driver; > udc->gadget.dev.driver = &driver->driver; > - dev_set_drvdata(&udc->gadget.dev, &driver->driver); > udc->enabled = 1; > udc->selfpowered = 1; > > @@ -1655,7 +1654,6 @@ static int at91_stop(struct usb_gadget *gadget, > spin_unlock_irqrestore(&udc->lock, flags); > > udc->gadget.dev.driver = NULL; > - dev_set_drvdata(&udc->gadget.dev, NULL); > udc->driver = NULL; > > DBG("unbound from %s\n", driver->driver.name); > -- > 1.7.10.4 Hi, I've tested it, and it works fine here. Tested-by: Mario Isidoro <Mario.Isidoro@xxxxxxxxx> Best regards, Mario Isidoro -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
