On Wed, Jul 18, 2012 at 12:54:31PM +0200, Sascha Hauer wrote: > On Wed, Jul 18, 2012 at 06:29:07PM +0800, Richard Zhao wrote: > > Signed-off-by: Richard Zhao <richard.zhao@xxxxxxxxxxxxx> > > --- > > arch/arm/boot/dts/imx6q-sabrelite.dts | 4 ++++ > > arch/arm/boot/dts/imx6q.dtsi | 19 +++++++++++++++---- > > arch/arm/mach-imx/clk-imx6q.c | 1 + > > 3 files changed, 20 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts > > index d42e851..c66ff9d 100644 > > --- a/arch/arm/boot/dts/imx6q-sabrelite.dts > > +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts > > @@ -62,12 +62,16 @@ > > aips-bus@02100000 { /* AIPS2 */ > > usb@02184000 { /* USB OTG */ > > vbus-supply = <®_usb_otg_vbus>; > > + disable-over-current; > > status = "okay"; > > }; > > > > usb@02184200 { /* USB1 */ > > status = "okay"; > > }; > > + usbmisc@02184800 { > > + status = "okay"; > > + }; > > Do we need to have this disabled initially in the SoC dtsi? It's in SoC, and don't affect anything outside of Soc. So I think it can be enabled by default. > > Also, common style in this file is to add a blank line between nodes. > Please keep it. yes. Thanks Richard > > Sascha > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html