On 17/07/2012, Felipe Balbi <balbi@xxxxxx> wrote: > On Tue, Jul 17, 2012 at 02:40:10PM +0530, Sachin Kamat wrote: >> Adds header file protection macros. > > you need to comment if you actually ran into an issue. Is there any file > which ends up with double inclusion of this header or are you just > trying to be safe ? Yes, it is only for safety to avoid multiple inclusion. I will update the commit message accordingly. > >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> --- >> include/linux/platform_data/s3c-hsotg.h | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/platform_data/s3c-hsotg.h >> b/include/linux/platform_data/s3c-hsotg.h >> index 97ec12c..ff5892d 100644 >> --- a/include/linux/platform_data/s3c-hsotg.h >> +++ b/include/linux/platform_data/s3c-hsotg.h >> @@ -12,6 +12,9 @@ >> * published by the Free Software Foundation. >> */ >> >> +#ifndef __LINUX_USB_S3C_HSOTG_H >> +#define __LINUX_USB_S3C_HSOTG_H __FILE__ > > you don't need to define it to __FILE__. #define __LINUX_USB_S3C_HSOTG_H > is enough. Ok. I will re-send with the above suggestions. > > -- > balbi > -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
